test: fix race condition in connection-handshake

metarhia / jstp

Fast RPC for browser and Node.js based on TCP, WebSocket, and MDSF

https://metarhia.github.io/jstp

Other

142 stars 10 forks source link

test: fix race condition in connection-handshake #260

Closed nechaido closed 7 years ago

aqrln commented 7 years ago

Strictly speaking, this doesn't have anything to do with macOS per se, it's just the bug hasn't been reproducing on Linux, so perhaps something like "test: fix race condition in connection-handshake" might be a better commit message.

Aside from that, the fact that it was only failing on macOS consistently makes it apparent that we need better platform coverage in CI, i.e., we should add macOS to the Travis configuration matrix and start using AppVeyor to test code on Windows.

aqrln commented 7 years ago

I'd want to fast-track this fix. Without the patch, tests are currently failing on master for me.

belochub commented 7 years ago

Landed in https://github.com/metarhia/jstp/commit/90c064c16fcb11622ac96b6f4be5277805f23519.