lint,deps: move ESLint config to a separate package

metarhia / jstp

Fast RPC for browser and Node.js based on TCP, WebSocket, and MDSF

https://metarhia.github.io/jstp

Other

142 stars 10 forks source link

lint,deps: move ESLint config to a separate package #302

Closed aqrln closed 7 years ago

aqrln commented 7 years ago

Move ESLint configuration to a separate package (eslint-config-metarhia). Also, bump ESLint to 4.6.1 (from 4.6.0) because that's what's specified in that package's peerDependencies.

aqrln commented 7 years ago

Failures (https://ci.appveyor.com/project/metarhia/jstp/build/140, https://ci.appveyor.com/project/metarhia/jstp/build/141) on Windows due to unsuccessful installation of uglifyjs-webpack-plugin@0.4.6 seem, obviously, unrelated.

aqrln commented 7 years ago

Also, how about converting YAML to JSON in ESLint configs? I've done that in a number of other repos, and JSON looks pretty good with small configs, while being kinda more native than YAML in JS ecosystem.

nechaido commented 7 years ago

Also, how about converting YAML to JSON in ESLint configs? I've done that in a number of other repos, and JSON looks pretty good with small configs, while being kinda more native than YAML in JS ecosystem.

I will not be against it now that the config is small.

aqrln commented 7 years ago

@nechaido @lundibundi updated, PTAL

aqrln commented 7 years ago

Landed in 79154c9488c29fb37d54b98aae41241a34e098d5.