search

metarhia / jstp

Fast RPC for browser and Node.js based on TCP, WebSocket, and MDSF
https://metarhia.github.io/jstp
Other
143 stars 10 forks source link

connection: use ping-pong instead of heartbeat #303

Closed nechaido closed 6 years ago

nechaido commented 6 years ago

Fixes: #217

belochub commented 6 years ago

There is no need to add test label to this PR, it is similar to the situation in https://github.com/metarhia/jstp/pull/190#issuecomment-304742538.

aqrln commented 6 years ago

There is no need to add test label to this PR, it is similar to the situation in #190 (comment).

Yup, not even lib. The subsystem should be just connection.

nechaido commented 6 years ago

@belochub @aqrln ping.

nechaido commented 6 years ago

Landed in 37918fec691890572cc21ddd0d92fa514bc5800a.