Sometimes CI fails on flaky test

metarhia / jstp

Fast RPC for browser and Node.js based on TCP, WebSocket, and MDSF

https://metarhia.github.io/jstp

Other

142 stars 10 forks source link

Sometimes CI fails on flaky test #327

Closed tshemsedinov closed 6 years ago

tshemsedinov commented 6 years ago

But it finished with success after restart FYI: @nechaido @belochub

not ok 8 - test/node/connection-emit-actions.js # time=20622.999ms
  ---
  timeout: 240000
  file: test/node/connection-emit-actions.js
  command: /home/travis/.nvm/versions/node/v8.9.4/bin/node
  args:
    - test/node/connection-emit-actions.js
  stdio:
    - 0
    - pipe
    - 2
  cwd: /home/travis/build/metarhia/jstp
  exitCode: 1

nechaido commented 6 years ago

Timeout has nothing to do with this test fail, time=20622.999ms is less than timeout: 240000. This was because the test didn't ignore ping\pong messages. This had been already fixed in https://github.com/metarhia/jstp/pull/326 and was landed in b4bf4f4.