search

metarhia / jstp

Fast RPC for browser and Node.js based on TCP, WebSocket, and MDSF
https://metarhia.github.io/jstp
Other
142 stars 10 forks source link

lib: realize reconnection by transport replacement #332

Closed belochub closed 6 years ago

belochub commented 6 years ago

This is also to be covered by unit tests, I hope @nechaido can help with that.

tshemsedinov commented 6 years ago

@belochub I think implement reconnection is the right caption

belochub commented 6 years ago

@tshemsedinov in this context, the words 'to realize' and 'to implement' are equivalent, and I've picked 'to realize' since it is shorter and using this word was the only way to fit the commit summary in 50 characters.

belochub commented 6 years ago

@lundibundi, ping, can you, please, take a look at this PR?

belochub commented 6 years ago

Ping, @lundibundi.

lundibundi commented 6 years ago

@belochub Hi, sorry, I'm a bit busy right now and don't have time to properly review this PR, feel free to merge this without my review.

belochub commented 6 years ago

Landed in https://github.com/metarhia/jstp/commit/8ff6423aae87ac222c98b6bdba6a8477f7aa6a2c and https://github.com/metarhia/jstp/commit/e1d8a920ecd7f73abca9250fa1ba41e684b10f18.