search

metarhia / jstp

Fast RPC for browser and Node.js based on TCP, WebSocket, and MDSF
https://metarhia.github.io/jstp
Other
142 stars 10 forks source link

deps: use prettier for code formatting #357

Closed nechaido closed 5 years ago

nechaido commented 6 years ago

@belochub @lundibundi @aqrln I would like your opinion on using prettier for automated code formatting in JSTP.

aqrln commented 6 years ago

My approval stands for "+1", but I'd say we must have a univocal approval instead of a simple "no rejections" for this to pass, as this deviates from the house style a bit (when applied organization-wise; for JSTP on its own Prettier actually makes the code style match the other Metarhia projects' one more closely). Also, to avoid inconsistencies throughout the codebase, we should consider making Prettier the house style if @tshemsedinov is fine with it.

nechaido commented 6 years ago

@tshemsedinov and @belochub PTAL.

belochub commented 6 years ago

You should also update tools/prepare-release.js file to generate correct markdown files with it.

belochub commented 5 years ago

Closing for now due to https://github.com/metarhia/jstp/pull/357#pullrequestreview-144928036.