test: add a missing regression test for GH-329

aqrln commented 6 years ago

Add a missing regression test for connectAndInspect with empty array of interfaces.

aqrln commented 6 years ago

@nechaido PTAL

aqrln commented 6 years ago

@nechaido @belochub I've pushed new commits to address the feedback, PTAL

aqrln commented 6 years ago

@nechaido @belochub please take another look

aqrln commented 6 years ago

Unrelated macOS failure:

not ok 30 - test/node/resendable-call-from-client.js # time=241094.551ms
  ---
  timeout: 240000
  file: test/node/resendable-call-from-client.js
  command: /home/travis/.nvm/versions/node/v6.14.3/bin/node
  args:
    - test/node/resendable-call-from-client.js
  stdio:
    - 0
    - pipe
    - 2
  cwd: /home/travis/build/metarhia/jstp
  ...
{
    ok 1 - must connect without errors
    not ok 2 - timeout!
      ---
      signal: SIGTERM
      handles:
        - type: ChildProcess
          events:
            - internalMessage
            - message
        - type: Pipe
        - type: Socket
          events:
            - end
            - finish
            - _socketEnd
            - data
            - error
            - close
      expired: TAP
      stack: |
        emit (node_modules/nyc/node_modules/signal-exit/index.js:77:11)
        process.listener (node_modules/nyc/node_modules/signal-exit/index.js:91:7)
        processEmit (node_modules/nyc/node_modules/signal-exit/index.js:155:32)
        processEmit (node_modules/signal-exit/index.js:155:32)
      test: TAP
      ...

    1..2
    # failed 1 of 2 tests
    # time=185627.749ms

    not ok 3 - timeout!
      ---
      expired: test/node/resendable-call-from-client.js
      ...
}

belochub commented 6 years ago

Landed in https://github.com/metarhia/jstp/commit/b18215b848e4a3551ee0a508699171966c96c61f.

metarhia / jstp

test: add a missing regression test for GH-329 #359