search

metarhia / mdsf

Metarhia Data Serialization Format
https://metarhia.com
Other
9 stars 1 forks source link

parser: use a non-deprecated Utf8Value constructor #23

Closed belochub closed 6 years ago

belochub commented 6 years ago

Okay, so, apparently it is deprecated in the latest versions of Node.js 8 and 10, but at the same time not available in Node.js 6. I think this PR may stay open until Node.js 6 reaches its End-of-life, which is going to happen quite soon (in April 2019).

aqrln commented 6 years ago

How about

#if NODE_MODULE_VERSION >= 57
  String::Utf8Value str(isolate, args[0]->ToString());
#else
  String::Utf8Value str(args[0]->ToString());
#endif
belochub commented 6 years ago

Landed in https://github.com/metarhia/mdsf/commit/9f7c7aec3b85e3b46a47d9e9a5fce207331e7638.