Fix streams - Githubissues

metarhia / metacom

RPC communication protocol for Metarhia stack 🔌

https://metarhia.com

MIT License

80 stars 40 forks source link

Fix streams #437

Closed mprudnik closed 1 year ago

mprudnik commented 1 year ago

[x] tests and linter show no problems (npm t)
[ ] tests are added/updated for bug fixes and new features
[x] code is properly formatted (npm run fmt)
[ ] description of changes is added in CHANGELOG.md
[ ] update .d.ts typings

Done:

server changes were discussed previously
client used server-side receives binary packets as instances of Buffer, not a Blob.
MetaReadable instantiation - just fixing how args are passed https://github.com/metarhia/metacom/blob/master/lib/streams.js#L28

tshemsedinov commented 1 year ago

Landed in https://github.com/metarhia/metacom/commit/6ea9c227c2a56b321c2a30773babfb74498a1335 and https://github.com/metarhia/metacom/commit/94e0d248adf6a21b8f4e7c848d9dec95a5fd17c9