search

metarhia / metasync

Asynchronous Programming Library for JavaScript & Node.js
https://metarhia.com
MIT License
205 stars 35 forks source link

Migrate /tests dir to metatests2 #382

Closed machendos closed 5 years ago

machendos commented 6 years ago

Closes:#378 this PR rewrite all usage of assert to metatests. Also was update usage of old API of metasync in /tests

machendos commented 6 years ago

Despite I used git mv, the github does not show changes in the file in a convenient form, instead it shows completely deleted and adding files. To see the difference, go to these commits: https://github.com/metarhia/metasync/pull/382/commits/846e7459182cb57dc5f63c11165186d4f376369f https://github.com/metarhia/metasync/pull/382/commits/2690a9ba1a1d771e2fee6f5a7a7d19bcf589235e

lundibundi commented 6 years ago

Also, could you use test.plan/test.pass in all tests that need to verify that callbacks are called?

belochub commented 6 years ago

You shouldn't make these stylistic changes manually when style can be updated automatically; to fix styling now, you can rebase on master and run npm run lint -- --fix. And you would have to do it eventually anyway to make it possible to land this PR.

belochub commented 6 years ago

Rebase on master, please.

lundibundi commented 5 years ago

Landed in https://github.com/metarhia/metasync/commit/c8e5a62e5088294521b48d9893cbcc353fe67f19.