search

metarhia / metatests

Extremely simple to use test framework and runner for Metarhia technology stack 🧪
https://metarhia.com
Other
18 stars 4 forks source link

Optimize dependencies #98

Closed SemenchenkoVitaliy closed 5 years ago

SemenchenkoVitaliy commented 6 years ago

Ref: https://github.com/metarhia/Metarhia/issues/25

lundibundi commented 6 years ago

I thought we wanted to move browser testing to a separate package? /cc @aqrln

aqrln commented 6 years ago

Yes, and even if we didn't, I don't think the approach in this PR would be correct either. peerDependencies are dependencies too, they are merely required to be installed by a depending package to enforce a specific dependency tree shape. So this PR doesn't solve anything; in fact, it even introduces more dependencies (by making a bunch of optionalDependencies hard non-optional peerDependencies). Even though it would work without installing them despite the errors that npm would print upon npm install, it's still invalid to do so.

SemenchenkoVitaliy commented 6 years ago

Then, can you create repository, so I can move runner for browser there?

tshemsedinov commented 6 years ago

@SemenchenkoVitaliy https://github.com/metarhia/metatests-test-runner

lundibundi commented 6 years ago

@tshemsedinov I think it should be metatests-browser or metatests-browser-runner?

SemenchenkoVitaliy commented 6 years ago

@lundibundi I'd prefer metatests-browser-runner since it won't be an independent package.

lundibundi commented 6 years ago

I think this can be closed. Feel free to reopen if you think there is anything to add in this PR.

SemenchenkoVitaliy commented 5 years ago

Closing until https://github.com/metarhia/metatests-browser-runner/pull/1 is landed and published.

SemenchenkoVitaliy commented 5 years ago

This was implemented in https://github.com/metarhia/metatests/pull/157.