search

metarhia / noroutine

Goroutine analogue for Node.js, spreads I/O-bound routine calls to utilize thread pool (worker_threads) using balancer with event loop utilization. 🌱
https://metarhia.com
MIT License
120 stars 11 forks source link

Fixed few typo, update typings and added missing property #15

Closed Wansmer closed 2 years ago

Wansmer commented 2 years ago

Hello. Did few minor changes:

  1. Fixed typo in error handler in init();
  2. Fixed typo in noroutine.d.ts (interface name) and added missing property monitoring;
  3. Added property target in ballancer for no dynamically create;
  4. Changed order of verification options in init(), because code below have no sense if module is not an object;
tshemsedinov commented 2 years ago

Thanks! @Wansmer It would be better to send separate PRs for such different changes in future

tshemsedinov commented 2 years ago

Landed in https://github.com/metarhia/noroutine/commit/2946f9238f5e68db805a4d74f7b842666443765c, https://github.com/metarhia/noroutine/commit/fd481e57449607b3b5f133c6cddc1d9d63fd9006, https://github.com/metarhia/noroutine/commit/8f0f790590db9ffb6bfa166a753bc4fac1d3e0bc, and https://github.com/metarhia/noroutine/commit/57950e682334c7fe28af8cc208afb0e213f39a6e