Closed david-waltermire closed 2 weeks ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Committer Notes
Created unit tests to confirm behavior for when a missing field value is encountered.
In XML, the resulting value is an empty string. This is true for both
<field></field>
and<field/>
cases. There is no great way to prevent this using XMLSchema validation, since these conditions are allowed.Depending on the data type implementation, the XML values will result in data type format errors, which are improved in this PR.
If the XML is converted into JSON or YAML, then the resulting content will be
"field": ""
.In JSON and YAML. the resulting value is a
null
value if"field": null
. These will be caught in JSON schema validation.This is an area where normalizing behavior across JSON/YAML and XML is extremely difficult. We may explore other options in the future, but for now #205 will need to kept in the backlog.
This PR also updates the Metaschema module bindings to ensure that missing fields are addressed there, eliminating missing field value warnings that were in the old bindings.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: