metasfresh / metasfresh-e2e-legacy

metasfresh End-2-End Testing project.
7 stars 1 forks source link

[low prio] Check z-index of modals and other views #184

Closed TheBestPessimist closed 5 years ago

TheBestPessimist commented 5 years ago

Test shall include:

Todo for developer (besides coding)

All Flags are ticked? Congratulations, you have delivered!

Test concept

An e2e test which checks which views (by view i mean: modals, navbar, overlays, notifications, the referenced documents, the action menu, etc.) are over (above) and under (below) other views.

We should somehow define some rules about the z-index of each of these views, and test that via cypress.

For example the modal of a process is under the navigation bar currently, which is wrong: https://github.com/metasfresh/me03/issues/1990#issuecomment-506684448


Example:

In the Sales invoice window (http://localhost:3000/window/167/1000000), when opening a process (eg. Gutschrift erstellen), the modal is below the navbar.

image

Navbar z-index: 100 image

Modal z-index: 98 image

siemiatj commented 5 years ago

This won't work if z-index is not in inline style. And in 99% of the time it'll be a pain to add. I don't see a reason for such a test tbh. Just setting the z-indexes to values that make sens is enough.