Picking Terminal: Detailed Picking Issues

[metas-mk]

Is this a bug or feature request?

Feature Request

What is the current behavior?

There are a few issues in Picking terminal that can be optimized. Please check proposals below.

Which are the steps to reproduce?

Open, try and see.

What is the expected or desired behavior?

The following issues can be optimized in Detailed Picking in Picking Terminal:

• Have a Config (see M_Picking_Config table) that decides if overdelivery is allowed in Picking or not. If not then user shall receive an error.
• In Action "Pick to new/ existing HU" the qty initially set shall be the remaining qty (qty to deliver - picked qty)
• The Packing Instructions shall be initially set to the one defined in Shipment Schedule

[metas-ts]

Hi, @metas-rc @metas-mk i just integrated the two PRs:

• https://github.com/metasfresh/metasfresh/pull/3531
• https://github.com/metasfresh/metasfresh-webui-api/pull/866

afaiu still todo for that particular item

• add field for the new M_Picking_Config column
• add a user friendly error message..afaiu right now it's a hardcoded message which the user would see

PS: i'm not setting the "master" label and not moving it to rollbout because afaiu not all is done yet, and we might loose track about what is and isn't supposed to be done now

[teosarca]

note to IT: the overdelivery is prevented only for some of the processes. We need to prevent it no matter how u do it.

[teosarca]

idea/loud thinking: I think we shall enforce the restriction in de.metas.handlingunits.picking.pickingCandidateCommands.ProcessPickingCandidateCommand.allocateHUToShipmentSchedule(I_M_HU). Mainly, have a flag for HU2PackingItemsAllocator.

Also please check/evaluate if we can enforce it on a lower level, like some M_ShipmentSchedule_QtyPicked interceptor...

[metas-rc]

de.metas.handlingunits.picking.pickingCandidateCommands.ProcessPickingCandidateCommand.allocateHUToShipmentSchedule(I_M_HU). Mainly, have a flag for HU2PackingItemsAllocator.

• Done

[metas-rc]

Also please check/evaluate if we can enforce it on a lower level, like some M_ShipmentSchedule_QtyPicked interceptor...

• I also did this. Please, let me know if this make the one above obsolete, or it is safer to keep them both

[metas-rc]

the overdelivery is prevented only for some of the processes.

• I left this in the code, too. Because the prevention happens earlier and I think it's more efficient to not get to the end before throwing the error, at least for these 2 processes from the original requirements.

[metas-rc]

@teosarca Please, review when you have time and let me know if I shall change something.

[metas-lc]

IT

1. login as sysadmin and go to Picking Configuration window (540382) => notice new flag: Allow Overdelivery OK => by default is set on N

2. create/complete a new sales order, qty TU 5 (x10 cu)

3. go to picking terminal and pick: pick 6 TUs: 4 LUs with 1 TU and 1 LU with 2 TUs => cannot pick. Err message: Eine Überlieferung ist nicht erlaubt. OK

4. login as sysadmin and set Allow Overdelivery on Y (see step 1)

5. login as admin, go back to picking and try to process that LU with 2 TUs => worked, no errors OK

6. go to shipment candidates and create inout => inout created fine, qty TU 6, qty 60 OK

7. set Allow Overdelivery back on N

8. go to picking and try to use Pick to new HU, with a qty bigger than ordered => you can't: Eine Überlieferung ist nicht erlaubt. OK

Summary: you can pick as many HUs as you want, (also pick CUs). You cannot process picked HUs to overdeliver You cannot Pick to new HU/ pick to existing HU to overdeliver