search

metasfresh / metasfresh-webui-frontend-legacy

metasfresh Webui Frontend
GNU General Public License v2.0
57 stars 35 forks source link

Calendar icon covers date field #1428

Open metas-lc opened 6 years ago

metas-lc commented 6 years ago

Is this a bug or feature request?

fr

What is the current behavior?

when editing a date in included tab gridview, the icon for calendar covers the date. If you want to see calendar, you have to press that icon

Which are the steps to reproduce?

  1. open product window, select one e.g. https://w101.metasfresh.com:8443/window/140/2005572
  2. go to cu-tu allocation tab
  3. double click to edit valid from image

=> the icon covers the date

What is the expected or desired behavior?

The icon and edit shall fit properly into the field, and the calendar shall appear by default similar to doublecklick on dropdown field.

ottosichert commented 6 years ago

Probably introduced in https://github.com/metasfresh/metasfresh-webui-frontend/pull/1398, 3e2bb1d6f55b813d57a01aa8b41c23f6cbcacf21 to be precise

wiadev commented 6 years ago

@metas-lc can you check this issue if it's still valid?

metas-lc commented 6 years ago

@wiadev i checked. issue is still valid

wiadev commented 6 years ago

@teosarca Can you update the size of Date to "M" on back-end?

screenshot at jan 11 12-20-45

teosarca commented 6 years ago

@metas-mk wdyt?

metas-mk commented 6 years ago

@wiadev Just checked locally before merge. Seems as if the Calendar fields are now not aligned properly anymore. See Sales order window window/143/1000311 as example. Pls also check in others. image

metas-mk commented 6 years ago

Restarted Server and checked again. Looks like this now image a) Icons are moved into the end of content (should be end of field) b) In case of date field (not datetime) the field length is reduced and bottom line is not expanded c) the calendar icons are smaller than before in main view. Please use the larger size in main view as before.

metas-lc commented 6 years ago

IT please check 1, 4 and 5

  1. checked again "valid from" in window 140 => the icon has a white background now, so it's not over the date, even if now part of date is hidden OK => the calendar appears same as icon on double click, but it's way higher. I think because it must fit on the page (have to check if it's wanted) image

CHECKED: shall appear under the date field. Use scrollbar on the right if it's not enough space to fit

  1. checked other date fields => are aligned properly and the icons are at the end of the field OK

  2. length of date fields are like on date+time fields OK

  3. icons are still small NOK OLD: image

NEW: image

  1. not related with this task: when you press the icon, shall calendar open? (to check) CHECKED: if possible, please implement here: when you press on the icon, calendar shall open
siemiatj commented 6 years ago

Is it only the size of the calendar icon that's left here screen shot 2018-04-03 at 9 25 14 pm

or do we want to somehow figure out a better placement of the calendar in table ?

screen shot 2018-04-03 at 9 44 58 pm

siemiatj commented 6 years ago

ping @metas-lc @metas-mk ^^

metas-lc commented 6 years ago

hi. i think it would be nice to have it right under the field. @metas-mk wdyt? i added some new lines here to see how it looks image

siemiatj commented 6 years ago

I think this might be problematic, as in case there's no room for the calendar we'd have to programatically make the window bigger.