search

metasfresh / metasfresh-webui-frontend-legacy

metasfresh Webui Frontend
GNU General Public License v2.0
57 stars 35 forks source link

Create purchase orders: Date promised format #1567

Closed metas-lc closed 6 years ago

metas-lc commented 6 years ago

Is this a bug or feature request?

bug

What is the current behavior?

dates pattern are different from one line to another

Which are the steps to reproduce?

  1. open sales order window. Create a new one or use this one https://w101.metasfresh.com:8443/window/143/1000404
  2. select the product line and go to actions. Run Create purchase orders => notice date on the first line and second line image

What is the expected or desired behavior?

both dates should have the same format. As far as i know, it's defined by the language from login

metas-lc commented 6 years ago

IT both lines have dates in this format: 23.02.2018 00:00:00 OK changed languages to DE and EN => in both cases dates have the same format OK? (if i set language to DE => other date fields are like 23.02.2018 00:00 if i set language to EN => other date fields are like 02/23/2018 12:00 AM )

siemiatj commented 6 years ago

@metas-mk @metas-ts @teosarca I guess we need to formalize this, as it's causing a bit of a mess. Right now in some places we use the default locale format provided by the Moment.js library, but in others we use some hardcoded format. How do we want to handle this ? Force our format everywhere no matter the language, or use the locale format everywhere, or some hybrid solution (but then it'd be best to have it written down somewhere).

teosarca commented 6 years ago

IMHO we shall use locale's format, in case that will work smooth. Because while, Europeans like to write dates like DD.MM.YYYY, Americans like MM/DD/YYYY which shall be perfectly OK.

@metas-mk wdyt?

metas-lc commented 6 years ago

talked with @metas-mk and shall be use locale's format (like Teo said)

metas-rc commented 6 years ago

Results of IT

Tested on webui