view rows invalidation websocket events improvements - Githubissues

metasfresh / metasfresh-webui-frontend-legacy

metasfresh Webui Frontend

GNU General Public License v2.0

57 stars 35 forks source link

view rows invalidation websocket events improvements #1627

Closed teosarca closed 4 years ago

teosarca commented 6 years ago

Is this a bug or feature request?

FR follow-up of https://github.com/metasfresh/metasfresh-webui-api/issues/810

What is the current behavior?

Which are the steps to reproduce?

Take following steps to setup your test case. (if does not work for you, pls ping me)

picking terminal: https://w101.metasfresh.com:8443/window/540345
select a line and press Pick...

Ok... so when processing or processing that line, backend will send invalidation events (via websocket) to invalidate the row on the left side.

After processing, the row is no longer present. So, when frontend will call .../byIds?ids=<ID> it will get 404.

After reactivating the line you just processed, the row on left shall reappear. Backend sends an websocket event again, about that row.

What is the expected or desired behavior?

On a websocket event which is about some row(s), frontend shall handle following cases (additionally):

when calling .../byIds?ids=<ID> if backend returns 404 or one of the records is missing from returned list, it shall remove that row from view
if the row is not present in the view, add it at the bottom

teosarca commented 4 years ago

closing because this issue was fixed by https://github.com/metasfresh/metasfresh-webui-frontend/issues/2224. remaining part to finish will be solved by https://github.com/metasfresh/metasfresh-webui-frontend/issues/2456