metasfresh / metasfresh-webui-frontend-legacy

metasfresh Webui Frontend
GNU General Public License v2.0
57 stars 35 forks source link

Edit mode in grid view when focus lost #1650

Closed metas-mk closed 6 years ago

metas-mk commented 6 years ago

Is this a bug or feature request?

Bug

What is the current behavior?

Currently, when editing a field in grid view, then leaving the field with TAB, the edit modus remains in that field. Double-clicking Outside in the same row works. Double-clicking outside in other rows does not work.

Which are the steps to reproduce?

Open, try and see. Go to contact Tab in https://w101.metasfresh.com:8443/window/123/2156438.

What is the expected or desired behavior?

When leaving a field in edit modus, then the field shall be switched to non-edit modus again automatically. image

metasnw commented 6 years ago

tested on master https://w101.metasfresh.com:8443/window/123/2156431 image

also tested on a branch system with latest master 5.48.1-8734+master

metasnw commented 6 years ago

@siemiatj also on latest master the edit view is not going back to normal when you click in another line or somehwere else

siemiatj commented 6 years ago

@metasnw I can't reproduce this. Any tips ?

pm6mibhf2g

metasnw commented 6 years ago

@siemiatj use the partner window and edit the string fields of the contacts there e.g. https://w101.metasfresh.com:8443/window/123/2156431

siemiatj commented 6 years ago

@metasnw I think something's wrong with the deployment again. It does work locally on master (in the same window), but it's broken on w101.

metasnw commented 6 years ago

@siemiatj I can confirm. It works on a docker branch test system :-) but not on w101

siemiatj commented 6 years ago

@metasnw so is this finally working, or not ?

metas-mk commented 6 years ago

@siemiatj checked on w101, yes, works on w101. moved to rollout so it can be tested further.

metas-lc commented 6 years ago

IT started to edit a field in included tab grid view => pressed on another row: field is not in edit mode anymore OK => pressed on same row, different field: field is not in edit mode anymore OK => pressed somewhere outside the tab: field is not in edit mode anymore OK