Allow decimal comma in Qty Fields

metasfresh / metasfresh-webui-frontend-legacy

metasfresh Webui Frontend

GNU General Public License v2.0

57 stars 34 forks source link

Allow decimal comma in Qty Fields #2005

Closed metas-mk closed 5 years ago

metas-mk commented 5 years ago

Is this a bug or feature request?

Bug

What is the current behavior?

Currently, only a decimal point is allowed to be used in Qty fields.

Which are the steps to reproduce?

Open, try and see.

What is the expected or desired behavior?

Also allow the usage of decimal comma.

Example in Sales Order Batch entry:

metas-dh commented 5 years ago

Results of IT1 tested in mf15

decimal comma in Qty Fields is allowed as well: OK
decimal comma is displayed as decimal point (=> inspect): is that OK?

2018-10-19 14_05_49-metasfresh

teosarca commented 5 years ago

@metas-dh IMHO it's OK. Btw, was your order line created with the correct qty?

metas-dh commented 5 years ago

thx; good thing you asked, bc i tested that a bit more:

when i had no Packing Item and the UOM was Kg, then the order line had the correct qty, as set (decimal): OK
when i had no Packing Item and the UOM was PCE, then the qty in ther order line was rounded, either up or down: is that OK?
when i had a Packing Item (both UOM Kg & PCE), then the qty in ther order line was rounded, but always down (=> 1 TU if i set 1,8 or 1,9): is that OK?
also, the qty in the order line is always displayed with decimal point, no matter if i used decimal point or comma in Qty Entry

teosarca commented 5 years ago

@metas-dh I think they are rounded because of the UOM precision or something like that. But those are (if they are) metasfresh issues and not frontend.