Document filters: don't send empty string valueTo when there is no valueTo

metas-dh commented 5 years ago

Bug

When you change the filter params sev. times, the results are not correct.

open e.g. sales order window/143
filter for bpartner TestKunde: => orders of that partner displayed, OK
add other filter params, e.g. for order no. or docstatus so you get no results
take out the params so that only param for bpartner TestKunde remains: => no results, NOK
What is the expected or desired behavior?

Shall work.

LE: because of https://github.com/metasfresh/metasfresh-webui-api/issues/1102, the effect of this task is canceled, but the requirement of not sending valueTo:"" remains.

teosarca commented 5 years ago

That's happening because frontend transmits the valueTo as '' (empty string). It shall send null.

siemiatj commented 5 years ago

I can't reproduce this. Since this was fixed on the backend I guess we can close it, right ?

teosarca commented 5 years ago

I guess we can close it, right ?

yes and no. I mean:

yes can close it with "won't fix" resolution because even if the frontend is still sending valueTo:"", backend defensively ignores it.
no we cannot close it because the actual task requirement was not solved. i.e. frontend is keep sending valueTo:"". Just reproduced now on w101:

teosarca commented 5 years ago

let's lower the priority because is no longer a show stopper and we shall fix it in future.

metasfresh / metasfresh-webui-frontend-legacy