search

metasfresh / metasfresh-webui-frontend-legacy

metasfresh Webui Frontend
GNU General Public License v2.0
57 stars 34 forks source link

Fix mobile/webui pagination #2293

Open ionut-movila opened 5 years ago

ionut-movila commented 5 years ago

Is this a bug or feature request?

Feature request

What is the current behavior?

Pages with tables are working very slow on mobile devices where all data is loaded from the start. Eg: /window/143.

Which are the steps to reproduce?

See above.

What is the expected or desired behavior?

On mobile devices table should work much faster and we already tested that having paginated data would solve it.

ionut-movila commented 5 years ago

We will try the quick fix first:

  1. Determine the number of rows we can show for a table on mobile without big impact on performance (aka double tap will still work)
  2. Only show this number of rows in mobile view
  3. If there are more rows that we don't show a message at the bottom will say "Total items ${noItems} (limited)", similar with message in desktop version.
  4. Nothing to be changed in desktop version.
ionut-movila commented 5 years ago

Here is a video with the quick fix: http://recordit.co/bkHvcux0y3

We have determined that 30 rows will work pretty good on mobile devices. I was able to test this on a real android device (Xiaomi Mi A1, Android Pie). I also tried to test on iOS with iPod touch 6th gen with iOS 10.3.3 (this has similar HW resources as an iPhone 6). But could not because app will not pass login screen. And I have seen a false response from API call /rest/api/login/isLoggedIn. Is this correct?

teosarca commented 5 years ago

as I understood from iPhone 6 users, logging in was not a problem.

siemiatj commented 4 years ago

Safari is just super dumb. To get it to work you need to enable all cookies storage. Here's how to do it on iOS https://help.vrbo.com/articles/Two-Factor-Authentication-Third-Party-Cookies