search

metaskills / less-rails-bootstrap

The most popular front-end framework for developing responsive, mobile first projects on the web for Rails asset pipeline.
561 stars 127 forks source link

Fix update_bootstrap.sh for compatibility with v.3.0.0 #86

Closed maxd closed 11 years ago

maxd commented 11 years ago

Hello,

This pull-request fix issues #83, #84 and #85. It clean app/assets directory before import LESS, JS and fonts from original Twitter Bootstrap repository.

Could you please approve it, create new gem and yank v.3.0.0.1?

Thanks

metaskills commented 11 years ago

OK, working on this now...

simi commented 11 years ago

Sorry guys for problems. update_bootstrap.sh is not bulletproof. It's good for small changes, but it can't handle bigger updates like we did recently from 2.3 to 3.0 upstream bootstrap version. I'll try to rewrite it. :+1: for this to merge.

thanks @maxd

metaskills commented 11 years ago

OK, I yanked 3.0.0.1 and published v3.0.1. @simi I think it is fine to use our own tiny version and only track major/minor for our bootstrap dep. So sticking with 3 numbers is just fine.

Can y'all confirm that this change still works for your systems? https://github.com/metaskills/less-rails-bootstrap/commit/995b237aa22b1a12b809bc4d233cd2983d601cd5

Thanks!

metaskills commented 11 years ago

Sorry guys for problems. update_bootstrap.sh is not bulletproof

No worries, I think the recent changes to the script will work for some time to come.

simi commented 11 years ago

@metaskills this works for me:

-sed -i '' 's#^\(@icon-font-path:[[:space:]]*\"\).*\(\";\)#\1twitter/bootstrap/\2#g' $lrb_fw_dir/variables.less
-sed -i '' 's#url(#asset-url(#g' $lrb_fw_dir/*.less
+sed -i 's#^\(@icon-font-path:[[:space:]]*\"\).*\(\";\)#\1twitter/bootstrap/\2#g' $lrb_fw_dir/variables.less
+sed -i 's#url(#asset-url(#g' $lrb_fw_dir/*.less
simi commented 11 years ago

@metaskills you can try it here - https://github.com/metaskills/less-rails-bootstrap/tree/fix-linux-sed