metasmile / grit-i18n

Automatically exported from code.google.com/p/grit-i18n
BSD 2-Clause "Simplified" License
1 stars 2 forks source link

Resource maps silently drop duplicated key field values #33

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
In resource_map.py the _FormatSource function builds a map from either path or 
name to resource id. If it encounters duplicate values it silently skips the 
duplicates. For name, duplicate values likely represent an error and should be 
reported. For path, duplicate values mean we are packing the same resource more 
than once (See https://code.google.com/p/grit-i18n/issues/detail?id=27). This 
is not necessarily an error but I feel that if we want to explicitly support 
this we should include both resource ids in the "map" which would be more of a 
multi-map at that point.

Original issue reported on code.google.com by flackr@chromium.org on 27 Aug 2015 at 9:50