Open zackteo opened 4 years ago
The relative file paths are wrong due to change in file structure like from
examples/contour-lines.vega.json to examples/vega/contour-lines.vega.json
examples/contour-lines.vega.json
examples/vega/contour-lines.vega.json
Should I also fix the ones in the README.md?
Like (def contour-plot (oz/load "examples/contour-lines.vega.json")) to (def contour-plot (json/parse-string (slurp "resources/oz/examples/vega/contour-lines.vega.json"))) ?
(def contour-plot (oz/load "examples/contour-lines.vega.json"))
(def contour-plot (json/parse-string (slurp "resources/oz/examples/vega/contour-lines.vega.json")))
Hi @zackteo. Thanks for pointing this out.
Yes, I'd greatly appreciate a PR to fix this. If you do though, please stick with the oz/load over -> slurp json/parse-string.
oz/load
-> slurp json/parse-string
Thanks again!
The relative file paths are wrong due to change in file structure like from
examples/contour-lines.vega.json
toexamples/vega/contour-lines.vega.json
Should I also fix the ones in the README.md?
Like
(def contour-plot (oz/load "examples/contour-lines.vega.json"))
to(def contour-plot (json/parse-string (slurp "resources/oz/examples/vega/contour-lines.vega.json")))
?