search

metasoarous / oz

Data visualizations in Clojure and ClojureScript using Vega and Vega-lite
Eclipse Public License 1.0
829 stars 74 forks source link

add scale for vega cli #160

Closed mn-dimension closed 3 years ago

mn-dimension commented 3 years ago

Hi

I have added scale for the vega/lite cli commands that enable scaling of the resulting png/svg files. I need this for better quality output. Without the scaling the images become blurred when a style sheet expands the image. I have defaulted the scale to 1 so there is no change to the current size.

This works well with export!

Cheers

metasoarous commented 3 years ago

Great! Thanks for submitting this!

I'm assuming you tested this and that it works properly? My only concern is that the command line flag doesn't have a space in it, and from the docs I'm not sure if this is supported (also, my vega-cli install is apparently borked at present).

Happy to merge once I get confirmation from you.

Thanks again!

mn-dimension commented 3 years ago

I have run this many times ( my setup is on MacOS ) and the image is scaled correctly.

-- The Continium

On 29 July 2021 at 18:20:21, Christopher Small @.**@.>) wrote:

Great! Thanks for submitting this!

I'm assuming you tested this and that it works properly? My only concern is that the command line flag doesn't have a space in it, and from the docs I'm not sure if this is supported (also, my vega-cli install is apparently borked at present).

Happy to merge once I get confirmation from you.

Thanks again!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/metasoarous/oz/pull/160#issuecomment-889323654, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMMBOT3ZBKG3PPWPN3CAY3TT2GEVLANCNFSM5BGQHDMA.

metasoarous commented 3 years ago

Perfect; Going to go ahead and merge then. Will try to cut a release soon; working on some other things that I hope to get in as well.

Thanks for the PR and the quick response!