thumbnails added - Githubissues

metaspace2020 / sm-engine

Engine for metabolite annotation for imaging mass spectrometry

Apache License 2.0

7 stars 5 forks source link

Closed Ren22 closed 6 years ago

intsco commented 6 years ago

@Ren22 the PR fails to pass the tests, plz take a look

Ren22 commented 6 years ago

@intsco seems that it happens because of the new field in the database, will check it

LachlanStuart commented 6 years ago

Has data migration been discussed? The existing datasets that have optical images will need to have thumbnails generated before we can deploy this.

intsco commented 6 years ago

@LachlanStuart good point. A migration script should also be provided

LachlanStuart commented 6 years ago

The migration script works for me. Here's what's left:

The test_dataset_manager test_add_optical_image test is failing because post_image gets called 4 times but the mock is only given 3 return values in the side_effects
This issue: https://github.com/METASPACE2020/sm-webapp/pull/39/files#r190954053