metaspartan / explorer

Ethereum Block Explorer (ETHExplorer V2) - Realtime Price Ticker, Shapeshift.io Integration, etc. (Project is currently not under active development, if you have a bug fix, please open a PR) My current project can be found at https://github.com/metaspartan/denarius (D a better cryptocurrency than ETH)
Other
485 stars 330 forks source link

controller('mainCtrl') runs multiple time #10

Open daragao opened 7 years ago

daragao commented 7 years ago

The main controller is being called multiple times: https://github.com/carsenk/explorer/blob/master/app/scripts/controllers/mainController.js#L4

This was not a problem when running locally geth and the server, but when I run them on different machines, there web3.eth.filter() is way to fast asking for updates and makes the frontend be sluggish.

Don't know if I messed something up, our if happens to anyone else, but it seems to be a mixture from multiple calls to the mainCtrl time the amounts of updates web3.eth.filter() does. Working on a simplification of this problem, unless it doesn't happen to anyone else

totomz commented 6 years ago

Yep, I can confirm this issue!

sthnaqvi commented 6 years ago

i also got same problem when i debug i found mainCtrl load three times - 1- https://github.com/carsenk/explorer/blob/f4bc04beb07c7e62f75ab86284c80d432bca6671/app/app.js#L30 2- https://github.com/carsenk/explorer/blob/f4bc04beb07c7e62f75ab86284c80d432bca6671/app/index.html#L35 3- https://github.com/carsenk/explorer/blob/f4bc04beb07c7e62f75ab86284c80d432bca6671/app/views/main.html#L4

Please clone from https://github.com/sthnaqvi/ethereum-blockchain-explorer fixed this issue. Thanks