metaspartan / explorer

Ethereum Block Explorer (ETHExplorer V2) - Realtime Price Ticker, Shapeshift.io Integration, etc. (Project is currently not under active development, if you have a bug fix, please open a PR) My current project can be found at https://github.com/metaspartan/denarius (D a better cryptocurrency than ETH)
Other
485 stars 330 forks source link

Zero returned for blockNumber #35

Closed chainhead closed 6 years ago

chainhead commented 6 years ago

Why would web3.eth.blockNumber return a zero? Should geth be run for a certain duration before explorer can work? In scripts/controllers/mainController.js, the function updateStats() fails if web3.eth.blockNumber returns 0. I used a work-around such that the blockNum used subsequently is always greater than equal to 0 and the -1 doesn't crash the application.

sthnaqvi commented 6 years ago

use this explorer already fixed it . https://github.com/sthnaqvi/explorer

chainhead commented 6 years ago

You mean this https://github.com/sthnaqvi/explorer/commit/39eaebef947be90d5e099013e148059b27a7f329?diff=split ? Just curious to know, what is this fix? I am not an Angular developer ...