metatron-app / metatron-discovery

Powerful & Easy way for big data discovery
https://metatron.app
Apache License 2.0
441 stars 112 forks source link

Description of latitude and longitude column #2237

Open jeongeunkwon opened 5 years ago

jeongeunkwon commented 5 years ago

Is your feature request related to a problem? Please describe. Map charts with latitude and longitude dimension are not created. (If it can be created, please tell me) But latitude and longitude column names make user feel like they can create map charts with the columns. Actually, I have received inquiries from a user about that.

Describe the solution you'd like It would be nice if we could give them a guide when people create datasources.

kyungtaak commented 5 years ago

@jeongeunkwon Hmm.. I think It would be better to eliminate this type of column. @AnnieHwang It's the same thing you told me last time. At that time I said I should just keep it but, I think it's okay to get rid of it. What do you think?

AnnieHwang commented 5 years ago

@kyungtaak Latitude and longitude are not used in Metatron Discovery, so I think that the type should be removed.

kyungtaak commented 5 years ago

@AnnieHwang It seems to be necessary according to #2189 issue. In terms of metadata or data preparation, latitude or longitude type of column seems to be meaningful. I think it would be better to keep the column type. I wish there was something in the map chart that gives the impression that only WKT types can be displayed. ex. changing icon, information statement

libran-sub commented 5 years ago

Is this issues on my phone

On Sun., 7 Jul. 2019, 10:15 am Kyungtaak Noh, notifications@github.com wrote:

@AnnieHwang https://github.com/AnnieHwang It seems to be necessary according to #2189 https://github.com/metatron-app/metatron-discovery/issues/2189 issue. In terms of metadata or data preparation, latitude or longitude type of column seems to be meaningful. I think it would be better to keep the column type. I wish there was something in the map chart that gives the impression that only WKT types can be displayed. ex. changing icon, information statement

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/metatron-app/metatron-discovery/issues/2237?email_source=notifications&email_token=AMQZRDUT7UJ2R52XMP2FV6DP6EYTPA5CNFSM4HYEJC7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLCJEI#issuecomment-508961937, or mute the thread https://github.com/notifications/unsubscribe-auth/AMQZRDW2ER5DUSTZGHBHDOLP6EYTPANCNFSM4HYEJC7A .

AnnieHwang commented 5 years ago

@kyungtaak Ok, i will talk with @joohokim1.