metatron-app / metatron-discovery

Powerful & Easy way for big data discovery
https://metatron.app
Apache License 2.0
440 stars 110 forks source link

Manage package-lock.json file in VCS #235

Open kyungtaak opened 5 years ago

kyungtaak commented 5 years ago

Is your feature request related to a problem? Please describe.

Report from Google Groups


While installing metatron discovery with command '$ mvn clean install -DskipTests' in  https://github.com/metatron-app/metatron-discovery, I get following ERROR messages. 
Despite the error messages metatron discovery install well. 

[INFO] > uglifyjs-webpack-plugin@0.4.6 postinstall /Users/goodljy 1/Z_metatron/metatron-discovery/discovery-frontend/node_modules/uglifyjs-webpack-plugin
[INFO] > node lib/post_install.js
[INFO]
[ERROR] npm notice created a lockfile as package-lock.json. You should commit this file.
[WARNING] npm WARN @angular/core@2.4.10 requires a peer of rxjs@^5.0.1 but none was installed.
[WARNING] npm WARN ng2-translate@5.0.0 requires a peer of @angular/core@^2.0.0 but none was installed.
[WARNING] npm WARN ng2-translate@5.0.0 requires a peer of @angular/http@^2.0.0 but none was installed.
[WARNING] npm WARN tsutils@3.0.0 requires a peer of typescript@>=2.8.0 || >= 3.1.0-dev but none was installed.
[WARNING] npm WARN @fimbul/bifrost@0.11.0 requires a peer of typescript@>= 2.7.1 || >= 3.0.0-dev || >= 3.0.0-insiders || 3.0.0-rc || >= 3.1.0-dev but none was installed.
[WARNING] npm WARN @fimbul/ymir@0.11.0 requires a peer of typescript@>= 2.7.1 || >= 3.0.0-dev || >= 3.0.0-insiders || 3.0.0-rc || >= 3.1.0-dev but none was installed.
[ERROR]
[INFO] added 1307 packages in 46.392s
[INFO] Date: 2018-09-14T08:40:40.635Z

Describe the solution you'd like This issue occurs because the package-lock.json file is not managed through VCS. (there is a well-documented web link )

This issue is not a problem right now. However, since we have a potential risk of build failure, we will consider managing it in VCS.

Describe alternatives you've considered <N/A>

Additional context <N/A>

kyungtaak commented 5 years ago

@eltriny @alchan-lee 해당 이슈 검토 부탁드립니다.

kyungtaak commented 5 years ago

@eltriny @alchan-lee 이건은 어서 결론은 내야할것 같네요.