search

metauni / metaboard

Multiplayer drawing boards for sharing knowledge in Roblox.
Mozilla Public License 2.0
29 stars 6 forks source link

Persistent subscriber boards can ignore IsFull #27

Closed dmurfet closed 2 years ago

dmurfet commented 2 years ago

Persistent boards will refuse input from the Canvas if they are full (i.e. board.IsFull.Value == true). However, if they are subscribed to another board they will continue to receive input and e.g. add lines that are drawn on the other board.

It's not clear to me what the desired behaviour here is. It would be easy to have boards not pass on any events to full persistent subscriber boards, but then this would break the assumption that subscriber boards are "exactly the same" as the original board. Note that if a persistent subscriber board is subscribed to multiple boards it can be full even if neither of the boards it is subscribed to are.

For the moment I have added a warning to the README that persistent subscriber boards are not officially supported.

dmurfet commented 2 years ago

Resolved in v0.4.4 by just not passing any events to full subscriber boards.