Closed zaquestion closed 4 years ago
There is a suggested change: https://github.com/golang/protobuf/pull/588 that would technically allow complication, though I'm not sure that is enough to actually make these CLIs function with oneof.
It seems like our implementation of the CLI clients will need to be aware of oneof
and generate flags for each of the underlying fields and enforce the "one of" behavior on itself. The underlying flags would then need to be place into types that can meet the underlying interface.
cli clients were removed.
Kinda weird issue using
oneof
, not sure how we're going to address. Service works correct and marshals as expected, but generated CLI is borkedsearch-service/svc/client/cli/handlers/handlers.go
Note above that
isSearchRequest_Search
doesn't have thepb.
package prefix, and even if it didisSearchRequest
is unexported which makes it challenging to reference hereservice.proto
service.pb.go