metaverse / truss

Truss helps you build go-kit microservices without having to worry about writing or maintaining boilerplate code.
Other
737 stars 144 forks source link

obviously the enums should be strings #283

Closed zaquestion closed 5 years ago

zaquestion commented 5 years ago

this got overlooked from the orginal jsonpb behavior since submitter was trying to maintain behavior, but strings is way better

before

$ curl -X POST localhost:5050/rack -d { "env": "prod" }
{"env":1"}

now

$ curl -X POST localhost:5050/rack -d { "env": "prod" }
{"env":"prod"}