Lots of changes - Githubissues

metaware / angular-invoicing

Create free and unlimited one off invoices using this little Invoicing app made with Angular JS

http://metaware.github.io/angular-invoicing/

661 stars 268 forks source link

Lots of changes #7

Closed yaworsw closed 10 years ago

yaworsw commented 10 years ago

Major changes

Switched from the table layout to one using divs.
Upgraded from bootstrap 3 RC to to bootstrap 3
Upgraded from angular 1.0.7 to 1.1.5 (although 1.1.5 is unstable)
Rewrote js/main.js
Removed jquery
Replaced the animation directive with and angular 1.1.5 css animation
Minor changes
Changed remove/add logo to toggle logo (will change back later using angular 1.1.5 ternary operator)
Changed "Add Item" to "[+]"
Lots of minor display changes caused primarily by the switch from tables to divs
Does not start with an extra empty invoice item

jasdeepsingh commented 10 years ago

Thank you for this Pull request - I'm loving all the clean up! :heart: reviewing now.

jasdeepsingh commented 10 years ago

One more breaking change I noticed was: Currently we are saving the users last saved invoice to their localStorage. This new update breaks that feature. I'm working on that feature. Will update this PR.

cc @manpreetrules

yaworsw commented 10 years ago

Thanks for the code review. If you don't fix the local storage issue I'll get it tomorrow.

yaworsw commented 10 years ago

Should be good to merge. Let me know what you think.

jasdeepsingh commented 10 years ago

Thank you for this PR. I'll update the GH pages within next couple days.

metaware / angular-invoicing

Lots of changes #7

Major changes

Minor changes