metbosch / homebridge-http-temperature

HomeBridge HomeKit Plugin for HTTP temperature endpoints
https://www.npmjs.com/package/homebridge-http-temperature
Apache License 2.0
33 stars 18 forks source link

Default max_temp does not handle southern summers! #23

Closed jlg89 closed 2 years ago

jlg89 commented 4 years ago

If you're using Celsius, none of this applies. If you're using Fahrenheit, the default min_temp is good for pretty much everyplace on earth except Antarctica. The default max_temp, though, doesn't cut it if you're within the 38th parallels. It's not a critical issue, but the max_temp default should probably be something like 120 or 130.

metbosch commented 3 years ago

I put the values thinking on extreme Celsius values. I will try to increase the value in the following releases. Thanks for the insight.

metbosch commented 2 years ago

Fixed in release 0.8.1

metbosch commented 2 years ago

Commit: https://github.com/metbosch/homebridge-http-temperature/commit/b99b6547e98513c14697581229d8d9b7b52677c1