search

metbosch / homebridge-http-temperature

HomeBridge HomeKit Plugin for HTTP temperature endpoints
https://www.npmjs.com/package/homebridge-http-temperature
Apache License 2.0
33 stars 18 forks source link

Password protected & single integer #5

Closed sbels closed 7 years ago

sbels commented 7 years ago

Is it possible to modify this plugin to:

1) Work without JSON. Read an integer value from a page that returns nothing but that integer value.

2) Work with a password protected page. Similar to homebridge-http, this would require username and password parameters.

metbosch commented 7 years ago

Hi @sbels, Both changes are possible. If you are planning to do the changes, let me know any PR will be welcome! Otherwise, I can try to take a look the following days and let you know in order to test the changes.

metbosch commented 7 years ago

Hi @sbels again, Can you try the changes in fix/issue#5 branch (https://github.com/metbosch/homebridge-http-temperature/tree/fix/issue%235)? Let me know if you are not familiar in how to change the npm installation files by the ones in the branch.

Thanks!

sbels commented 7 years ago

@metbosch - Someone else gave me a hand modifying the code (see attached). This works. Note that I also had to do some conversion as Homekit kept interpreting the value as Celcius. Sorry to waste any time! index.js.txt

metbosch commented 7 years ago

I'm closing the issue since it should be fixed in version 0.3.1

sbels commented 7 years ago

Thanks - I'll switch to this version.

On Jul 27, 2017, at 10:30 AM, metbosch notifications@github.com wrote:

I'm closing the issue since it should be fixed in version 0.3.1

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

metbosch commented 7 years ago

@sbels, let me know if you found any issue. Take a look at README since the config options are not exactly the ones in your source code.