search

meteatamel / knative-tutorial

A collection of samples for Knative Serving, Knative Eventing and Knative-GCP projects.
Apache License 2.0
482 stars 131 forks source link

Fix broker creation step #82

Closed benmoss closed 3 years ago

benmoss commented 3 years ago

When I ran the kubectl label command I didn't see a Broker appear in my default namespace. I asked on Slack and people told me this was the recommended way to create a broker now.

meteatamel commented 3 years ago

Hi @benmoss, thanks for the PR. It looks to me that Broker injection should work with label, as long as the Sugar Controller is installed. If this is true, I'll keep the label command and add a note to tell people how to create the Broker if Sugar Controller is not installed. Sounds good?

benmoss commented 3 years ago

Yep, the sugar controller is apparently not installed by default anymore, so it might make sense to flip the order, but that sounds good to me

meteatamel commented 3 years ago

I just added a new "Broker Creation" page where I show both ways of creating a Broker and linked to it from different parts of the tutorial. Closing this PR. Thanks again!