search

metebalci / pdftitle

a utility to extract the title from a PDF file
GNU General Public License v3.0
131 stars 21 forks source link

ran pylint and fixed issed #11

Closed jakob1379 closed 4 years ago

jakob1379 commented 4 years ago

I have changed the code to fit to standards from mypy and pylint. these changed do not change the way the code works, but are rather just small changes to remove useless code and prevent potential issues.

metebalci commented 4 years ago

Sorry for my late reply. Thanks for recommending the pylint checks. I had to modify more than in your pull request and disable some pylint checks after a later commit so I am not merging this but I believe I did all or almost all the changes you recommended - and mentioned your recommendation in the README. This will be in v0.7.

jakob1379 commented 4 years ago

Sorry for my late reply. Thanks for recommending the pylint checks. I had to modify more than in your pull request and disable some pylint checks after a later commit so I am not merging this but I believe I did all or almost all the changes you recommended - and mentioned your recommendation in the README. This will be in v0.7.

No worries! I'm just happy that you found it helpful 😁