search

meteor-factory / react-native-tinder-swipe-cards

Tinder-like swipe cards for your React Native app
MIT License
1.13k stars 301 forks source link

useNativeDriver whenever possible #144

Open eyalyoli opened 4 years ago

eyalyoli commented 4 years ago

Configure Animted to useNativeDriver whenever possible to:

  1. Improve animation performance
  2. Remove useNativeDriver not set warnings
RookTKO commented 3 years ago

I think this causes conflicts with the ability to stack because we are using useNative everywhere. @eyalyoli thoughts?

eyalyoli commented 3 years ago

I'll check the stack option. I moved this to a newer version of the project check - https://github.com/swaplet/react-native-swipe-cards-deck

eyalyoli commented 3 years ago

@RookTKO yes it is a problem, the fix is simply to replace top with translateY and left with translateX in lines 387, 391 when defining style at renderStack(). I fixed this in react-native-swipe-cards-deck.

Although it seems to me that stack mode had issues in the original meteor-factory/react-native-tinder-swipe-cards lib. Maybe you can help to fix these issues...

RookTKO commented 3 years ago

@eyalyoli yea I'll working on trying to resolve them. Seems that they work on ios but not android atm.