Feature/space logger - Githubissues

meteor-space / base

Foundation for Modular Application Architecture in Meteor.

MIT License

75 stars 5 forks source link

Feature/space logger #23

Closed rhyslbw closed 8 years ago

rhyslbw commented 8 years ago

Global Space.Configuration.log.enabled property set via ENV var, defaulting to false Logging functionality handled using the powerful and well supported Winston npm package. Only a single Console transporter now, but I've done an outline of a Meteor Mongo Collection Custom Transporter that we can use to persist errors to the db. That can be a generic tool either within space or not.

[x] Finalise the log points
[x] Implement changes to any constructors to ensure the logs are rich
[x] Decide if we want to bring in module scoped logging using the Module Configuration API now or if global is fine.

rhyslbw commented 8 years ago

Ready for review @DominikGuzei

Know issue: Client side logger can be started/stopped without authorisation, and limiting this isn't really the scope of this feature as it's related to permissions.

rhyslbw commented 8 years ago

Still have the first two items from the first comment too

DominikGuzei commented 8 years ago

Great, looks like good first version to work with :wink: we can still do the refactoring to singleton / module later on as it wont be a breaking change. Let's move on for now!

The only thing that's strange about this PR is that it pulled in all of my changes in the other PR although they already have been merged … not the most exciting "feature" of Github :stuck_out_tongue:

rhyslbw commented 8 years ago

Yep agreed, I will do the once-over in the morning and resolve the conflicts. I manually merged the last merged PR, so that may be the problem