meteor-space / base

Foundation for Modular Application Architecture in Meteor.
MIT License
75 stars 5 forks source link

Feature/logger improvements #29

Closed rhyslbw closed 8 years ago

rhyslbw commented 8 years ago

Previously there were two instances of Space.Logger being created, one for low level logging and the other created and mapped when the top-level module was initiated. This was being done to isolate the low level lifecycle log events, but there’s a better way to do this using logging levels.

Now the top-level module just maps the Space.log instance to ‘log’ instead of creating a new one and we can use 8 levels to categorise the log message.

Breaking Changes:

New config options

I still need to:

rhyslbw commented 8 years ago

@DominikGuzei I've made this available for review early in case you can suggest anything else for this before we add additional Transports for sending logs to an external service, or persisting errors to Mongo.

DominikGuzei commented 8 years ago

Looks great! Also nice to see you're starting to use our .eslintrc :stuck_out_tongue:

rhyslbw commented 8 years ago

@DominikGuzei this is ready to go, although do I need to disable logging in the other tests?

DominikGuzei commented 8 years ago

Which other tests do you mean?

rhyslbw commented 8 years ago

Actually this is just related to me not cleaning up, as logging is off by default.

rhyslbw commented 8 years ago

Actually it was a persistent ENV starting the logger which was running in the application and module tests. Ready now

DominikGuzei commented 8 years ago

ok great! i will merge as soon as tests are green

rhyslbw commented 8 years ago

So it would be good to upgrade the other modules to use this logger now. I don't want to cause a merge conflict, so maybe you can upgrade it as part of an existing branch

DominikGuzei commented 8 years ago

i think all other modules are on develop now :wink: im not working on modules anymore, just the example for the workshop

rhyslbw commented 8 years ago

:+1: