Feature/logger improvements

[rhyslbw]

Previously there were two instances of Space.Logger being created, one for low level logging and the other created and mapped when the top-level module was initiated. This was being done to isolate the low level lifecycle log events, but there’s a better way to do this using logging levels.

Now the top-level module just maps the Space.log instance to ‘log’ instead of creating a new one and we can use 8 levels to categorise the log message.

Breaking Changes:

• SPACE_LOG_ENABLED replaces SPACE_SYSLOG_ENABLED,
• SPACE_APPLOG_ENABLED removed from spec

New config options

• SPACE_LOG_MIN_LEVEL restricts logging to types above one of the following: debug, info, notice, warning, error, crit, alert, emerg

I still need to:

• [x] Add tests to cover the level logic
• [x] Handle client side level restriction

[rhyslbw]

@DominikGuzei I've made this available for review early in case you can suggest anything else for this before we add additional Transports for sending logs to an external service, or persisting errors to Mongo.

[DominikGuzei]

Looks great! Also nice to see you're starting to use our .eslintrc :stuck_out_tongue:

[rhyslbw]

@DominikGuzei this is ready to go, although do I need to disable logging in the other tests?

[DominikGuzei]

Which other tests do you mean?

[rhyslbw]

Actually this is just related to me not cleaning up, as logging is off by default.

[rhyslbw]

Actually it was a persistent ENV starting the logger which was running in the application and module tests. Ready now

[DominikGuzei]

ok great! i will merge as soon as tests are green

[rhyslbw]

So it would be good to upgrade the other modules to use this logger now. I don't want to cause a merge conflict, so maybe you can upgrade it as part of an existing branch

[DominikGuzei]

i think all other modules are on develop now :wink: im not working on modules anymore, just the example for the workshop

[rhyslbw]

:+1: