make it actually possible to BDD test a custom app instance

meteor-space / base

Foundation for Modular Application Architecture in Meteor.

MIT License

75 stars 5 forks source link

make it actually possible to BDD test a custom app instance #82

Closed DominikGuzei closed 8 years ago

DominikGuzei commented 8 years ago

This fixes the BDD test helper on Space.Module and Space.Application to actually accept a second param that can be a existing app instance. We need that in the projection-rebuilding-example because there we just export a singleton app instance instead of the class. Anyway … this fix is necessary either way :wink:

rhyslbw commented 8 years ago

@qejk FYI

darko-mijic commented 8 years ago

@DominikGuzei: can you please add entry to the changelog so I can do a release.

darko-mijic commented 8 years ago

@DominikGuzei this sounds like a feature to me and 4.2.0 release. Are you sure this is a bug fix?

DominikGuzei commented 8 years ago

Yes, that's a bugfix for a feature that should have worked right from the beginning :wink:

darko-mijic commented 8 years ago

I don't think @rhyslbw would agree ;)

darko-mijic commented 8 years ago

I will do a release later today...