meteor-space / base

Foundation for Modular Application Architecture in Meteor.
MIT License
75 stars 5 forks source link

Fix/deprecated babel dependency #87

Closed qejk closed 7 years ago

qejk commented 8 years ago

There is issue with this deprecated dependency (only while running tests since its test-wise only), that causes:

=> Started proxy.
=> Started MongoDB.
=> Babel active on file extensions: es6.js, es6, jsx

/Volumes/sys_user/.meteor/packages/coffeescript/.1.0.16.c8royp++os+web.browser+web.cordova/plugin.compileCoffeescript.os/npm/node_modules/meteor/promise/node_modules/meteor-promise/promise_server.js:116
      throw error;
            ^

Intention of this PR is to fix that.

Have no idea how to rewrite test injector_annotations.unit.es6 since have no knowledge how decorator @ works behind scene and its not supported in ecmascript(afaik?):

https://github.com/meteor/meteor/issues/6057 https://github.com/pbastowski/angular-meteor-babel/issues/16#issuecomment-198779426 https://github.com/meteor/meteor/issues/6926

DominikGuzei commented 8 years ago

i guess this is for you @Sanjo 😉

ghost commented 8 years ago

Decorators seems to be currently not supported by the Meteor ecmascript package (see https://github.com/meteor/meteor/issues/6057). So you may remove the decorator support.