search

meteor-space / event-sourcing

CQRS and Event Sourcing Infrastructure for Meteor.
MIT License
63 stars 9 forks source link

Hotfix/commit timeout bug #73

Closed rhyslbw closed 8 years ago

rhyslbw commented 8 years ago

There's one test that still failing but need a fresh set of eyes on this @DominikGuzei can you review? Please note this PR is not intended to be merged, as its a hotfix, so will be handled manually, being back-merged into develop locally then synced.

Summary

Fixes https://github.com/meteor-space/event-sourcing/issues/39, also adding the race condition logic to ignore attempts to fail a commit publish that has since completed successfully.

rhyslbw commented 8 years ago

Thanks to a pooch review from @qejk this is now ready for final eyes before I merge @DominikGuzei and @darko-mijic . I really need this in ASAFP, and it's a really small scoped PR, so let's do this!

rhyslbw commented 8 years ago

Also I updated from develop when it was intended to be a hotfix, so let's just plan to roll out the new version afterwards as that will also make the dependency injection feature available. I'll close and re-open against develop