meteor-utilities / react-list-container

Smart containers for React & Meteor
32 stars 8 forks source link

[wip] React Komposer instead of mixins #8

Closed xavxyz closed 8 years ago

xavxyz commented 8 years ago

I found a way to use react-komposer dynamically with DocumentContainer & ListContainer, tested it in practice on Nova.

After reading different issues & discussions, in order to fit more with the react way,I defined component as a required props, so there is now only one-way to "contain": <Container component={MyDumbComp} />.

I'm having some issues with the infinite scrolling, the whole list re-renders. I guess it's related to https://github.com/kadirahq/react-komposer/issues/2 & https://github.com/kadirahq/react-komposer/issues/4, maybe it'll be fixed with https://github.com/kadirahq/react-komposer/pull/99.

Any feedback welcomed 👍

SachaG commented 8 years ago

Should we merge it now or wait for the fix? Is the issue just with infinite scrolling or with any type of pagination?

xavxyz commented 8 years ago

We should wait a little, in fact it maybe also related to the way I handle the loading component (doc: https://github.com/kadirahq/react-komposer#change-the-loading-component)

I'll try something with the loading component and ref to the list (doc:https://github.com/kadirahq/react-komposer#ref-to-base-component)

This custom loading component receives all the props passed to the UI Component as well. So, based on those props, you can change the behaviour of the loading component also.

xavxyz commented 8 years ago

I guess it's not relevant anymore, closing this :octocat: