search

meteor-vue / vue-meteor

🌠 Vue first-class integration in Meteor
897 stars 111 forks source link

Fixes #350, makes source maps line up with the correct lines in DevTools #370

Closed GeoffreyBooth closed 5 years ago

GeoffreyBooth commented 5 years ago

This one-line PR fixes #350, where the source maps are offset by the number of lines above the <script> opening tag:

image

(Line 14 is supposed to be highlighted, not line 21. And the brighter-colored line numbers should correspond with the lines where there is source code; picture them shifted up 8 lines each.)

Once this is merged in, not only will debugger statements be highlighted on the proper line, but you can also just click on the line number in the gutter in DevTools to set a breakpoint on that line (you know, how it’s supposed to work). Fixes akryum:vue-coffee too.

GeoffreyBooth commented 5 years ago

Thanks so much @Akryum! Do you mind please publishing a new version to Atmosphere?

Akryum commented 5 years ago

Will do soon