meteor / cordova-plugin-meteor-webapp

Cordova plugin that serves a Meteor web app through a local server and implements hot code push

MIT License

66 stars 74 forks source link

Switch versions explicitly #62

Closed wojtkowiak closed 6 years ago

wojtkowiak commented 6 years ago

This changes switching versions to be done explicitly with call to WebAppLocalServer.switchToPendingVersion instead of trying to switch every time a browser reload is detected.

This is another part of extracted fixes from @matdurand's commits.

This and the other PRs were running on production in my company's fork more than 1 year now.

Refs:

48

meteor/meteor#8063 (comment)

Fixes: https://github.com/meteor/cordova-plugin-meteor-webapp/issues/29

benjamn commented 6 years ago

Any idea about those test failures?

KoenLav commented 6 years ago

@benjamn AFAICT the changes in this PR are unrelated to these errors; they all mention 403 responses.

KoenLav commented 6 years ago

@wojtkowiak do these changes mean that Meteor will no longer automatically switch to a new version, whenever it becomes available, but we have to call this newly added function to switch versions?

I think that would be nice, but it should definitely be configurable (I guess that would need to happen in the package responsible for hot-reload rather than this cordova plugin though).

menelike commented 6 years ago

@KoenLav take a look at https://github.com/meteor/meteor/pull/10219

lorensr commented 5 years ago

Maybe related to test failures? Not clear to me why the testing if statement is taken out