search

meteor / cordova-plugin-meteor-webapp

Cordova plugin that serves a Meteor web app through a local server and implements hot code push
MIT License
66 stars 74 forks source link

HCP for Android emulator #84

Closed RealHandy closed 4 years ago

RealHandy commented 4 years ago

I've messed up something in git and i'm not gonna easily figure it out, but all I wanted to put in this PR is this one-line change: HCP for android emulator b922e08

Won't this allow HCP to work in the android emulator? It's working for me now, and I don't see the danger of it, since it only changes localhost, which means it has to be the emulator, right?

Side question -- can someone explain how there's a 1.7.0 of this plugin when the repo is only at 1.6.5?

Thanks, and sorry for the messy PR!

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

menelike commented 4 years ago

@RealHandy I am sorry to tell you this, but no one is gonna merge this with 919 changes in the PR when only https://github.com/meteor/cordova-plugin-meteor-webapp/commit/b922e080c0b8ee31e593f286222a9fe9a7d0dd74 is intended to be included.

May I suggest you create a new clean PR for this?

RealHandy commented 4 years ago

Yeah, it’s a mess, I’ll do another when I get a chance. Do you know why the release version of the plugin is 1.7.0 when the repo is only at 1.6.5?

On Oct 24, 2019, at 2:36 AM, menelike notifications@github.com wrote:

 @RealHandy I am sorry to tell you this, but no one is gonna merge this with 919 changes in the PR when only b922e08 is intended to be included.

May I suggest you create a new clean PR for this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

RealHandy commented 4 years ago

I'm going to resubmit this without all the extra files.