meteor / eslint-plugin-meteor

🧐 Meteor specific linting rules for ESLint
https://medium.com/@dferber90/8f229ebc7942
MIT License
118 stars 20 forks source link

Remove unnecessary "plugins" from example config #779

Closed Strajk closed 4 years ago

Strajk commented 4 years ago

Hi πŸ‘‹ First of all, thanks for your work πŸ‘

I've noticed that there is an unnecessary plugins field in the example config. The plugin is already included in the meteor/recommended config which is being extended https://github.com/dferber90/eslint-plugin-meteor/blob/master/lib/index.js#L24

Examples from other repos:

React https://github.com/yannickcr/eslint-plugin-react

Vue https://github.com/vuejs/eslint-plugin-vue

dferber90 commented 4 years ago

Thanks for your PR and for caring about eslint-plugin-meteor. I decided not to merge the PR as not every user will use "extends": ["plugin:meteor/recommended"]. Some might just want to define the rules individually, in which case they'll need to register the plugin..

So it's good to show how the plugin can be registered by default. There's also no harm in registering it twice. Hope this is understandable ☺️

Strajk commented 4 years ago

@dferber90 no worries, thanks for explanation :) keep up the great work πŸ‘